Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable no-spaced-func rule as @typescript-eslint/func-call-spacing replaces it #246

Open
pmk1c opened this issue Oct 6, 2021 · 0 comments

Comments

@pmk1c
Copy link

pmk1c commented Oct 6, 2021

Using defineEmits from Vue Setup API, I get an ESLint error for the rule no-spaced-func.
This rule has been deprecated since ESLint 3.3.0 and is replaced by func-call-spacing. Therefore it does not have a counterpart in typescript-eslint, but it doesn't need one, since there is @typescript-eslint/func-call-spacing.

So I think it is safe and better to disable this rule for this package.

Example Code, that gets a false positive:

const emit = defineEmits<{
  (e: 'update', value: string): void;
}>();
sodatea added a commit to sodatea/javascript that referenced this issue Aug 8, 2022
This rule was deprecated since ESLint v3.3.0 and replaced by the
`func-call-spacing` rule.
https://eslint.org/docs/latest/rules/no-spaced-func

`func-call-spacing` was enabled in this package long ago:
airbnb@27dcb99

So there's no need for it to stay in the ruleset.

Besides, it is causing some tricky issues when overriding the rules for
TypeScript support (iamturns/eslint-config-airbnb-typescript#246)
ljharb pushed a commit to sodatea/javascript that referenced this issue Aug 10, 2022
This rule was deprecated since ESLint v3.3.0 and replaced by the
`func-call-spacing` rule.
https://eslint.org/docs/latest/rules/no-spaced-func

`func-call-spacing` was enabled in this package long ago:
airbnb@27dcb99

So there's no need for it to stay in the ruleset.

Besides, it is causing some tricky issues when overriding the rules for
TypeScript support (iamturns/eslint-config-airbnb-typescript#246)
VenusPR added a commit to VenusPR/JavascriptRichardFirst that referenced this issue Mar 9, 2023
This rule was deprecated since ESLint v3.3.0 and replaced by the
`func-call-spacing` rule.
https://eslint.org/docs/latest/rules/no-spaced-func

`func-call-spacing` was enabled in this package long ago:
airbnb/javascript@27dcb99

So there's no need for it to stay in the ruleset.

Besides, it is causing some tricky issues when overriding the rules for
TypeScript support (iamturns/eslint-config-airbnb-typescript#246)
Binary-Ninja-007 pushed a commit to Binary-Ninja-007/JavaScript_Style_Guide that referenced this issue Aug 13, 2023
This rule was deprecated since ESLint v3.3.0 and replaced by the
`func-call-spacing` rule.
https://eslint.org/docs/latest/rules/no-spaced-func

`func-call-spacing` was enabled in this package long ago:
airbnb/javascript@27dcb99

So there's no need for it to stay in the ruleset.

Besides, it is causing some tricky issues when overriding the rules for
TypeScript support (iamturns/eslint-config-airbnb-typescript#246)
harry908nilson pushed a commit to marcolane/Javascriipt that referenced this issue Sep 1, 2023
This rule was deprecated since ESLint v3.3.0 and replaced by the
`func-call-spacing` rule.
https://eslint.org/docs/latest/rules/no-spaced-func

`func-call-spacing` was enabled in this package long ago:
airbnb/javascript@27dcb99

So there's no need for it to stay in the ruleset.

Besides, it is causing some tricky issues when overriding the rules for
TypeScript support (iamturns/eslint-config-airbnb-typescript#246)
olehrab pushed a commit to olehrab/JavaScript that referenced this issue Sep 14, 2023
This rule was deprecated since ESLint v3.3.0 and replaced by the
`func-call-spacing` rule.
https://eslint.org/docs/latest/rules/no-spaced-func

`func-call-spacing` was enabled in this package long ago:
airbnb/javascript@27dcb99

So there's no need for it to stay in the ruleset.

Besides, it is causing some tricky issues when overriding the rules for
TypeScript support (iamturns/eslint-config-airbnb-typescript#246)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant