Update @typescript-eslint to v6 #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iamturns could you review this and merge? |
benjaminatfrw
approved these changes
Jul 12, 2023
rivajunior
reviewed
Jul 13, 2023
|
Thanks @dartess :) |
|
@iamturns Looks like the CI release failed. |
|
Hi @iamturns , when will this be published on NPM? |
|
Looking into it now, some tokens have expired Hopefully |
|
🎉 This PR is included in version 17.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Great 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@iamturns hey!
Sorry for the notice.
typescript-eslintrecently released version 6 with a large set of changes: https://typescript-eslint.io/blog/announcing-typescript-eslint-v6/ . Unfortunately, without changing the peer-deps of your package, we cannot upgrade.Also i removed those dependencies from dev-deps. It looks like they are not involved in any way during the development of the package. If i am wrong please tell me and i will get back and update them.It was reverted.I tested the package locally in my codebase and didn't find any problems.
I will be grateful for the review and release of the new version. I don't see any visible changes to how this package works, so this shouldn't be a breaking change for users.
Closed #324