Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I could not get the windows build command to work.... #81

Open
gutow opened this issue Sep 24, 2022 · 3 comments
Open

I could not get the windows build command to work.... #81

gutow opened this issue Sep 24, 2022 · 3 comments

Comments

@gutow
Copy link
Contributor

gutow commented Sep 24, 2022

I think something is missing from the described setup. I can get the following build command to work on Windows, but not the full one described in the build_instructions.md:

pyinstaller -p src --clean --onefile --add-data="src;." -y -w --icon=src/assets/icon.ico --name=open-mcr src/main_gui.py

This, of course, just yields an .exe file not an installer.

As I am not really a Windows user, I am not sure how important not having an installer is. For my use cases just getting the .exe is fine.

@gutow
Copy link
Contributor Author

gutow commented Oct 11, 2022

The issue may simply be that NSIS may not install properly on the machines I have access to. Is it necessary?

@gutow
Copy link
Contributor Author

gutow commented Oct 11, 2022

Maybe just change the instructions to two steps: 1. create the .exe; 2. create installer if desired.

@iansan5653
Copy link
Owner

The issue may simply be that NSIS may not install properly on the machines I have access to. Is it necessary?

Yes, NSIS is necessary to build the installer exe file.

Maybe just change the instructions to two steps: 1. create the .exe; 2. create installer if desired.

I think that makes sense 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants