Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple replacements in a string are not working properly #48

Open
pavel-mailpoet opened this issue Jan 28, 2020 · 2 comments
Open

Multiple replacements in a string are not working properly #48

pavel-mailpoet opened this issue Jan 28, 2020 · 2 comments

Comments

@pavel-mailpoet
Copy link

I am using react-string-replace for translations. I have a string and I want to replace a couple of substitutes.
The code looks like this:

ReactStringReplace(
    '[link]This is my link[/link] available everywhere or [shortcode].',
    /(\[link\].*\[\/link\])|(\[shortcode\])/g,
    (match) => {
      console.log('match', match);
    }
  )

From my understanding, my regular expression should match only the first link and the [shortcode]. But the result in the console looks like this:

match [link]This is my link[/link]
match  available everywhere or 
match [shortcode]

I don't understand why is the middle match there. It doesn't match the regular expression.

@mikelpmc
Copy link

It seems like the library only accepts one group on the passed regex.
Try it with /(\[link\].*\[\/link\]|\[shortcode\])/g

The output now should be:
match [link]This is my link[/link]
match [shortcode]

@nahumzs
Copy link

nahumzs commented Oct 10, 2020

this totally took my off-balance, shouldn't this be part of the README.md page? :)

I can do the PR if you feel like this is relevant information for anyone who wants to use the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants