Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(polars): more accurate type mapping for timestamps #8479

Open
jcrist opened this issue Feb 27, 2024 · 0 comments · May be fixed by #8954
Open

refactor(polars): more accurate type mapping for timestamps #8479

jcrist opened this issue Feb 27, 2024 · 0 comments · May be fixed by #8954
Assignees
@ncclementi
Labels
onboarding Issues that can be addressed by someone less familiar with ibis polars The polars backend refactor Issues or PRs related to refactoring the codebase

Comments

@jcrist
Copy link
Member

jcrist commented Feb 27, 2024

Since the ibis timestamps have a scale we can do more accurate conversions here using dtype.unit.short. I assume this was the previous conversion logic from the backend implementation. Since it requires additional testing it could you please create a follow-up ticket so we improve this later?

Originally posted by @kszucs in #8478 (comment)
@jcrist jcrist added refactor Issues or PRs related to refactoring the codebase polars The polars backend onboarding Issues that can be addressed by someone less familiar with ibis labels Feb 27, 2024
@ncclementi ncclementi self-assigned this Mar 7, 2024
@ncclementi ncclementi linked a pull request Apr 12, 2024 that will close this issue
Open
@ncclementi ncclementi mentioned this issue Apr 26, 2024
Open
11 tasks
@ncclementi ncclementi mentioned this issue May 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ncclementi ncclementi

Labels
onboarding Issues that can be addressed by someone less familiar with ibis polars The polars backend refactor Issues or PRs related to refactoring the codebase
Projects
Ibis planning and roadmap
Status: review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(polars): add more accurate type mapping for timestamps ncclementi/ibis
2 participants
@jcrist @ncclementi