Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification of ProjectionPoseRoll direction #822

Open
ls-2037 opened this issue Apr 7, 2024 · 4 comments
Open

Clarification of ProjectionPoseRoll direction #822

ls-2037 opened this issue Apr 7, 2024 · 4 comments
Labels
clarifications spec_main Main Matroska spec document target

Comments

@ls-2037
Copy link

ls-2037 commented Apr 7, 2024

It's unclear what is meant by the "forward vector" in the ProjectionPoseRoll element documentation (https://www.matroska.org/technical/elements.html#ProjectionPoseRoll). As a result, some players rotate clockwise and some rotate counter-clockwise.

It is stated unambiguously in the specification notes (https://www.matroska.org/technical/notes.html#rotation) that the correct video display rotation direction for a positive ProjectionPoseRoll value is counter-clockwise. I wanted to confirm that that was the case: ProjectionPoseRoll=90 should cause the video to be rotated 90 degrees counter-clockwise during playback.

See also mpv-player/mpv#13830.

@robUx4 robUx4 added clarifications spec_main Main Matroska spec document target labels Apr 14, 2024
@robUx4
Copy link
Contributor

robUx4 commented Apr 14, 2024

Yes ProjectionPoseRoll without a pitch/yaw corresponds to a standard counter-clockwise rotation. The text comes from @dericed at bc02d12. I assume forward means an axis going towards you as opposed to backward that would go further from you.

Not sure what a more mathematical unambiguous term could be.

@kasper93
Copy link

kasper93 commented Apr 14, 2024

@Nevcairiel @v0lt Do you agree to implement this change in your projects? I will handle the update for mpv, but I'd like to synchronize with you both to ensure we make these changes around the same time. This coordination will help prevent confusion among users.

EDIT: Since the mpv 0.38 release is around the corner we decided to pull it in before. So there is that for waiting on others...

@v0lt
Copy link

v0lt commented Apr 14, 2024

Do you agree to implement this change in your projects?

I would like to see 2 MKV reference samples rotated by +90 and -90 degrees. A good sample would be a vertical video shot on a regular smartphone and converted to MKV.

@v0lt
Copy link

v0lt commented Apr 15, 2024

https://github.com/hubblec4/Matroska-Playback/blob/master/src/Rotate.md

These samples are bad because all files have the same video stream, which looks correct when nothing is rotated.

I'd like to see reference samples that only look right after rotation. A good example is a video shot on a smartphone (when the sky is above and the grass is below).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarifications spec_main Main Matroska spec document target
Projects
Development

No branches or pull requests

4 participants