-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Request] Support for conventional module paths - needed for godocs
& binaryd
#3737
Comments
@Olshansk, for the first issue, the problem was when you scaffold your chain, you should use the commands
For the second one, you can use the output flag into the build command: And maybe you need to change the name of your default module to the exact name of the chain so you can scaffold again in the default module, or you should specify the |
@Olshansk any updates? |
@Pantani Apologize for the delay!
👍 cc @okdas for context
Figure 1Figure 2 |
@Pantani Have you had a chance to see my response on the updates? |
Once you have scaffolded the chain, imho it makes sense that renaming the whole go module should be manual. |
Note: There may be certain flags/configs we haven't found that can fix this. If it is that easy, would really appreciate you directing in that direction!
Background
At pokt.network, we are currently using ignite to build the next version of the protocol using Rollkit on Celestia.
Issues
We recently hit 3 issues:
Godocs
- Ability to generate godocs generated at pkg.go.devBinaryd
- Ability to specify a binary named after completing (1)Scaffolding
- Ability to continue usingignite scaffold
after implementing (1) and (2)Issue 1 - Godocs
In order to have docs generated at pkg.go.dev, we had to implement poktroll/pull/128 which involved:
module pocket
withmodule github.com/pokt-network/poktroll
ingo.mod
import "pocket/..."
withimport "github.com/pokt-network/poktroll/..."
Though we do have nice godocs now, it created downstream issues.
Ref: https://pkg.go.dev/github.com/pokt-network/poktroll
Issue 2 - Binary Name
After implementing the changes above, we had to rename all instances of
pocketd
withpoktrolld
as seen in poktroll/pull/157. We would like to be able to easily specify what this binary name should beIssue 3 - Scaffolding
After making the changes in (1), we are no longer able to run commands such as
ignite scaffold list olsh --module supplier supplier_address session_id root_hash --no-message --yes
due to the discrepancy betweenpocket
(the name we used during scaffolding) andpoktroll
, the name in the repo.The text was updated successfully, but these errors were encountered: