Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(templates): scaffold module migrations #3902

Closed
wants to merge 0 commits into from
Closed

Conversation

julienrbrt
Copy link
Member

Closes: #3843


// Migrations
PlaceholderMigrationsRegister = "// this line is used by starport scaffolding # migrations/register"
PlaceholderMigrationsMigrator = "// this line is used by starport scaffolding # migrations/migrator"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not particular to this update but generally, should the comments say "Ignite scaffolding"?

// MigrateStore migrates the module to consensus version {{ num }}.
func MigrateStore(ctx context.Context, storeService corestoretypes.KVStoreService, cdc codec.BinaryCodec) {
// Insert {{ num }} migration here.
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

}
}

// this line is used by starport scaffolding # migrations/migrator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// this line is used by starport scaffolding # migrations/migrator
// this line is used by starport scaffolding # migrations/migrator

@salmad3 salmad3 added the skip-changelog Don't check changelog for new entries label Jan 30, 2024
@github-actions github-actions bot added component:docs Documentation additions or improvements. component:cmd type:services Service-related issues. type:internal component:packages labels May 29, 2024
@github-actions github-actions bot removed component:docs Documentation additions or improvements. component:cmd type:services Service-related issues. type:internal component:packages labels May 29, 2024
@julienrbrt julienrbrt closed this May 29, 2024
@julienrbrt julienrbrt deleted the julien/migrations branch May 29, 2024 20:50
@julienrbrt
Copy link
Member Author

Reopening this.

@julienrbrt julienrbrt restored the julien/migrations branch May 30, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ci CI/CD workflow and automated jobs. component:configs component:templates skip-changelog Don't check changelog for new entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scaffold migrations
2 participants