Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary Send requirement on Sleeper::Sleep? #54

Open
jessa0 opened this issue Apr 16, 2022 · 0 comments
Open

Unnecessary Send requirement on Sleeper::Sleep? #54

jessa0 opened this issue Apr 16, 2022 · 0 comments

Comments

@jessa0
Copy link

jessa0 commented Apr 16, 2022

I'm trying to use backoff::future::Retry using gloo-timers::future::TimeoutFuture as Sleeper::Sleep on WASM/Web, which is !Send. Sleeper currently requires type Sleep to be Send, but it seems this is not strictly necessary for the operation of Retry. I do understand, however, it'd technically be a visible API change to remove the Send bound, since the trait is public and not sealed, but it doesn't seem like a breaking change for the intended use of the Sleeper trait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant