Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a Load External Audio menu item #4843

Open
low-batt opened this issue Mar 5, 2024 · 1 comment · Fixed by #4844
Open

Provide a Load External Audio menu item #4843

low-batt opened this issue Mar 5, 2024 · 1 comment · Fixed by #4844
Assignees
@low-batt
Labels
feature: ui/ux progress: fixed/implemented type: enhancement

Comments

@low-batt
Copy link
Contributor

low-batt commented Mar 5, 2024

What you want IINA to do:
Provide a Load External Audio… menu item in the Audio menu under the existing Audio Track menu item.

What IINA does currently:
IINA supplies a Load External Audio Track… button on the AUDIO tab of the quick settings panel.

Why you think this should be added:
To be consitent with how a similar feature for subtitles is handled.

For subtitles IINA provides a Load External Subtitle… menu item under the Subtitles menu as well as a Load Subtitle… button on the SUBTITLES tab of the quick settings panel.
@low-batt low-batt self-assigned this Mar 5, 2024
low-batt added a commit that referenced this issue Mar 5, 2024
@low-batt
Close provide a Load External Audio menu item, #4843
347da92 
This commit will:
- Add a "Load External Audio" menu item to the MainMenu XIB
- Add a loadExternalAudio outlet to MenuController
- Add a menuLoadExternalAudio method to MainMenuActionHandler
@low-batt low-batt mentioned this issue Mar 5, 2024
Merged
2 tasks
@low-batt low-batt linked a pull request Mar 5, 2024 that will close this issue
Close provide a Load External Audio menu item, #4843 #4844
Merged
2 tasks
svobs pushed a commit to svobs/iina-advance that referenced this issue Apr 27, 2024
@low-batt @svobs
Close provide a Load External Audio menu item, iina#4843
2ac3226 
This commit will:
- Add a "Load External Audio" menu item to the MainMenu XIB
- Add a loadExternalAudio outlet to MenuController
- Add a menuLoadExternalAudio method to MainMenuActionHandler
uiryuu pushed a commit that referenced this issue May 22, 2024
@low-batt
Close provide a Load External Audio menu item, #4843 (#4844)
a976a49 
This commit will:
- Add a "Load External Audio" menu item to the MainMenu XIB
- Add a loadExternalAudio outlet to MenuController
- Add a menuLoadExternalAudio method to MainMenuActionHandler
@low-batt
Copy link
Contributor Author

Changes to implement this feature have been merged into the IINA develop branch. GitHub automatically closed the linked issue in reaction to the merge. I am reopening this issue until this feature is available in an official release of IINA. Once this feature has been included in an official release this issue will be closed.

@low-batt low-batt reopened this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@low-batt low-batt

Labels
feature: ui/ux progress: fixed/implemented type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close provide a Load External Audio menu item, #4843 iina/iina
1 participant
@low-batt