You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Expected behavior:
The text fields under the slider for the Speed setting on the VIDEO tab of the quick settings panel are properly aligned with the tick marks they are intended to label.
Actual behavior:
Currently IINA does not support any right to left languages. However PR #4922 enables Hebrew. If you build IINA with that pull request and set Hebrew as the language then show the video panel the labels under the slider for the Speed settings are misaligned:
The labels should look like this:
I believe this problem is responsible for these constraint errors:
Errors displayed in Xcode console::
Unable to simultaneously satisfy constraints:
(
"<NSLayoutConstraint:0x600000852670 H:[NSTextField:0x11fe5dac0]-(>=0)-[NSTextField:0x11fe5ddf0] (active)>",
"<NSLayoutConstraint:0x600000852530 NSTextField:0x11fe5dac0.centerX == 0.667*NSSlider:0x11fe4b490.trailing (active)>",
"<NSLayoutConstraint:0x600000852620 NSTextField:0x11fe5ddf0.trailing == NSSlider:0x11fe4b490.trailing (active)>",
"<NSLayoutConstraint:0x600000852760 H:[NSSlider:0x11fe4b490]-(8)-[NSTextField:0x11fe5e120] (active)>",
"<NSLayoutConstraint:0x600000852710 NSTextField:0x11fe5e120.trailing == NSTextField:0x11fe5e450.leading (active)>",
"<NSLayoutConstraint:0x600000852800 H:[NSTextField:0x11fe5e450]-(0)-| (active, names: '|':NSView:0x11fe4b260 )>"
)
Will attempt to recover by breaking constraint
<NSLayoutConstraint:0x600000852530 NSTextField:0x11fe5dac0.centerX == 0.667*NSSlider:0x11fe4b490.trailing (active)>
Set the NSUserDefault NSConstraintBasedLayoutVisualizeMutuallyExclusiveConstraints to YES to have -[NSWindow visualizeConstraints:] automatically called when this happens. And/or, set a symbolic breakpoint on LAYOUT_CONSTRAINTS_NOT_SATISFIABLE to catch this in the debugger.
This commit will:
- Add outlets for speed slider labels and other components to the
QuickSettingViewController class
- Add outlets for constraints controlling the position of speed slider
labels to the QuickSettingViewController class
- Add methods awakeFromNib, calculateSliderLabelMultiplier and
viewWillLayout to the QuickSettingViewController class to replace
constraints when in a right to left layout
- Add a convertSpeedToSliderValue method to the
QuickSettingViewController class to eliminate duplication of a
formula
These changes cause IINA to replace the layout constraints that control
the position of the labels under the speed slider in the video panel
that identify the speed associated with particular slider tick marks
with constraints that properly position the slider labels when the user
interface layout direction is right to left.
System and IINA version:
Expected behavior:
The text fields under the slider for the
Speed
setting on theVIDEO
tab of the quick settings panel are properly aligned with the tick marks they are intended to label.Actual behavior:
Currently IINA does not support any right to left languages. However PR #4922 enables Hebrew. If you build IINA with that pull request and set Hebrew as the language then show the video panel the labels under the slider for the
Speed
settings are misaligned:The labels should look like this:
I believe this problem is responsible for these constraint errors:
Errors displayed in Xcode console::
Steps to reproduce:
Pull PR feat: enable hebrew locale #4922
Open the IINA project in Xcode
Under the
Product
menu open theScheme
menu and selectEdit Scheme…
Click on the
Options
tabScroll down to the
App Language
settingIn the pull down select
Hebrew
Start IINA running under Xcode
Start playing a video
Press ⇧⌘V to show the video panel
Notice the labels under the slider for
Speed
are misaligned or missingMPV does not have this problem.
mpv does not support localization.
How often does this happen?
Every time.
The text was updated successfully, but these errors were encountered: