Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL causes icons to overlap with the text in the Quick Settings tabs #4925

Open
1 task done
ShlomoCode opened this issue May 10, 2024 · 2 comments
Open
1 task done

Comments

@ShlomoCode
Copy link

System and IINA version:

Expected behavior:

The icons do not overlap with the label text in right-to-left languages such as Arabic and Hebrew.

Actual behavior:

Currently IINA does not support any right-to-left languages. However PR #4922 allows Hebrew. If you build IINA with this pull request and set Hebrew as the language then the tabs labels in IINA quick settings overlap the labels. (see screenshots below)

Screenshots:

CleanShot 2024-05-10 at 05 18 48@2x
CleanShot 2024-05-10 at 05 23 59@2x

Steps to reproduce:

  • Open the IINA project in Xcode
  • Under the Product menu open the Scheme menu and select Edit Scheme…
  • Click on the Options tab
  • Scroll down to the App Language setting
  • In the pull down select Right-to-Left Pseudolanguage near the end of the list
  • Start IINA running under Xcode
  • Open Quick Settings
  • Notice that the icons overlap the text

However, only two of the 3 tabs seem to overlap. It might help with the investigation.

  • MPV does not have this problem.

mpv does not support localization.

How often does this happen?

Every time.

@low-batt
Copy link
Contributor

I will look into this.

@low-batt
Copy link
Contributor

These are buttons that have an image and a title. The buttons are configured with Image Hugs Title. The problem is that the images are not centered:
video
audio
subtitles

In addition the alignment is not uniform between the images. This is why when reversed with an RTL language the SUBTITLES button has a larger gap between the image and the title compared to the other tabs.

One solution would be to create a second set of images for when the title is left of the image.

One of the IINA developers who are able to create images will need to fix this issue.

@low-batt low-batt removed their assignment May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants