Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failing on Windows 10 #86

Open
mfaheemakhtar opened this issue Dec 24, 2019 · 0 comments
Open

Test failing on Windows 10 #86

mfaheemakhtar opened this issue Dec 24, 2019 · 0 comments

Comments

@mfaheemakhtar
Copy link

mfaheemakhtar commented Dec 24, 2019

Tests are failing on my Windows 10 Pro Education 64-bit.

I found that aliases[alias] = nodePath.join(base, aliases[alias]) is adding base path + alias (absolute) path resulting in an invalid location.

Changing join to resolve fixes the issue.
aliases[alias] = nodePath.resolve(base, aliases[alias])

#51 is also affected.

Please note that tests can't run on Windows using yarn run test. The command must be changed from "testonly": "NODE_ENV=test mocha test/specs.js", to "testonly": "SET NODE_ENV=test & mocha test/specs.js", in package.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant