Error when running on production env

[freddygymlib]

Hello,

running the example https://github.com/zeit/next.js/tree/master/examples/with-next-page-transitions on production env triggers an error:

TypeError: Cannot read property 'isRequired' of null
at Object. (/home/freddy/Workspace/workspace-projects/workspace-together/with-next-page-transitions/node_modules/next-page-transitions/lib/PageTransition.js:300:37)

Which refers to this: line 300 - PageTransition.js
timeout: _PropTypes.timeoutsShape.isRequired,

When looking from the origin of the problem, I found this line on the react-transition-group dependency

var timeoutsShape = process.env.NODE_ENV !== 'production' ? _propTypes.default.oneOfType([_propTypes.default.number, _propTypes.default.shape({ enter: _propTypes.default.number, exit: _propTypes.default.number }).isRequired]) : null;

Note: this problems does not appear on the 1.0.0-alpha.1 release because back then we had on PageTransition.js:

timeout: _PropTypes.timeoutsShape

Regards,

Freddy

[freddygymlib]

Hello,

Becareful, I think there is a small typo in the pull request #18

code removed: loadingCallbackName: 'pageTransitionReadyToEnter',
new code: loadingCallbackName: 'pagessTransitionReadyToEnter',

Regards,

Freddy

[teleginzhenya]

@freddygymlib thanks will fix it, it is all about MacBook Pro 2017 keyboard :(

[nwalters512]

Looks like this was caused by reactjs/react-transition-group#448. Will take a look at the PR!

[vincivince]

Hi all, any moves to deploy a fix ?
Thx

[ScottMorse]

I made a pull request #21 using the fix I used most recently with an app I deployed. Right now I have to use my custom copy of the source in my project since the Node packages are installed and built remotely.

It allows for the timeout and loadingTimeout's prop types (the react-transition-group's custom timeoutsShape type) to still be required in development, but avoids these errors seen in production.

Let me know if it seems like the fix you are looking for.

[genox]

@ScottMorse thanks, gonna use your fork meanwhile 👍

[nwalters512]

Resolved by the PR from @ScottMorse in #21 - I'll release a version containing the fix shortly.

[fr3fou]

So can it now be used in production?

[ScottMorse]

I am using it now in my Next app in production and it's working! https://www.pymusician.com