Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adaptive_threshold lacks the delta parameter #532

Closed
stephanemagnenat opened this issue Jun 15, 2023 · 2 comments
Closed

adaptive_threshold lacks the delta parameter #532

stephanemagnenat opened this issue Jun 15, 2023 · 2 comments
Labels
good first issue

Comments

@stephanemagnenat
Copy link
Contributor

The OpenCV equivalent of adaptive_threshold has delta parameter (they call it C in the documentation), which is necessary in many use cases.

Currently the imageproc equivalent miss it. I need it, so I rewrote the function. I'll be happy to contribute the extended version in a PR, maybe we can name it adaptive_threshold_with_delta and let the old one use the new version with 0 as delta. That way, the API is not broken.

What do you think?
@theotherphil
Copy link
Contributor

This would a welcome addition if you’re still up for creating the PR. Thanks.

@Dantsz Dantsz mentioned this issue May 22, 2024
Merged
@theotherphil
Copy link
Contributor

Added in #637

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephanemagnenat @theotherphil