Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should export all public types #228

Open
gstamac opened this issue Oct 9, 2019 · 1 comment
Open

Should export all public types #228

gstamac opened this issue Oct 9, 2019 · 1 comment

Comments

@gstamac
Copy link

gstamac commented Oct 9, 2019

Currently only functions and some consts are exported in type definition. But all types that are used in this functions as parameters or results should be exported too. As far as I can see ISizeCalculationResult and CallbackFn are missing but there might be others.
@schardev
Copy link

@netroy is there any blocker in exporting available types? Or should I open a PR if you are willing to merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gstamac @schardev