-
Notifications
You must be signed in to change notification settings - Fork 54
update gifsicle binary to 1.92 (lossy compression support) #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@XhmikosR I don't mean to be a pest, but any chance we could get an updated gifsicle build? Right now I have to manually build gifsicle to get lossy compression support, and I'd much rather just pull in |
Sure, I just didn't notice sooner. |
Windows binaries added. The other platforms are pending which need someone else to provide the binaries. |
Hello All, Any updates on the binaries for other platforms? @mreinstein Could you please let me know how can I do the manual build to import the latest binary? |
Attached the instructions on how I did it. That said I don't understand why this isn't merged yet. This is an important feature. Most people that would want to run gifsicle for web image optimization want compression. To the powers that be, can we please merge this? Is there some holdup I'm not aware of on why we haven't? building gifsiclespin up an amazon linux 64 bit x86 ec2 AMI (x86 64 bit is super important, that ensures we're on the same platform that lambda runs on) login to the ec2 instance and run this: sudo yum update
sudo yum install autoconf intltool
sudo yum groupinstall "Development Tools"
wget https://github.com/kohler/gifsicle/archive/v1.92.tar.gz
tar -xzf v1.92.tar.gz
cd gifsicle-1.92
autoreconf -i
./configure --disable-gifview
make then logout and run: scp -i sp-tmp.pem ec2-user@18.233.161.219:/home/ec2-user/gifsicle-1.92/src/gifsicle /Users/me/my-project/gifsicle |
The problem is that I can't test this myself, otherwise I'd have merged it. /CC @sindresorhus |
I've updated the macOS binary, but I don't currently have a Linux VM. If someone wants an updated Linux binary, submit a PR with a Docker script or something I can simply run to get the binary. |
@sindresorhus I don't know much about docker, but if it would help I could create a .pem file, and give you access to an amazon ec2 server so that you could build and retrieve this binary. Would that suffice? Just let me know where to send the .pem file (email perhaps?) And I'll happily send it along. |
This is partially solved by 8635120. |
Released yesterday, and adds lossy compression support to gifsicle. kohler/gifsicle#72
The text was updated successfully, but these errors were encountered: