Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paths containing ) don't work #381

Open
looeee opened this issue May 13, 2021 · 1 comment
Open

Paths containing ) don't work #381

looeee opened this issue May 13, 2021 · 1 comment

Comments

@looeee
Copy link

looeee commented May 13, 2021 •
edited

I'm running this piece of code on about 10k JPG and PNG images:

  const processedImg = await imagemin([originalPath], {
    plugins = [
      imageminJpegtran(),
      imageminOptipng({
        optimizationLevel: 1,
      }),
    ];
  }).catch((err) => {
    console.error(`Imagemin error: ${originalPath}`);
    console.error(err);
  });

  if (!processedImg || !processedImg[0]) {
    console.error(`Error: no processedImg for ${originalPath}`);
    return;
  }

  await fs.promises
    .writeFile(processedPath, processedImg[0].data)
    .catch((err) => {
      console.error(`Error writing: ${originalPath}`);
      console.error(err);
    });

Most of the images process successfully, but the following errors are returned. What you'll notice in common for these files is that they all have some amount of ) characters in their path.

Error: no processedImg for (WIP) Chaffee in Desert/thumbnail.png
Error: no processedImg for 711 (gas station)/thumbnail.png
Error: no processedImg for Agave Tequiliana (Blue Weber)/thumbnail.png
Error: no processedImg for Anchor Inn (Site 4)/thumbnail.png
Error: no processedImg for Arctic Fox (Sitting)/ArcticFox_Diffuse.png
Error: no processedImg for Arctic Fox (Sitting)/thumbnail.png
Error: no processedImg for Armoire CHIC196 (L100cm)/chic196_back_plywood.jpg
Error: no processedImg for Armoire CHIC196 (L100cm)/chic196_bottom_plywood1.jpg
Error: no processedImg for Armoire CHIC196 (L100cm)/chic196_front.jpg
Error: no processedImg for Armoire CHIC196 (L100cm)/chic196_handle_horizontal1.jpg
Error: no processedImg for Armoire CHIC196 (L100cm)/chic196_sides.jpg
Error: no processedImg for Armoire CHIC196 (L100cm)/chic196_top.jpg
Error: no processedImg for Armoire CHIC196 (L100cm)/Metal_Seamed.jpg
Error: no processedImg for Armoire CHIC196 (L100cm)/thumbnail.png
Error: no processedImg for Arnold (Hey Arnold)/thumbnail.png
Error: no processedImg for Bad Boy)))/thumbnail.png
Error: no processedImg for Barbarian Warlord (NSFW)/thumbnail.png
Error: no processedImg for bedford-nostrand G (wip)/thumbnail.png
Error: no processedImg for Big Ben (See description)/BigBen.jpg
Error: no processedImg for Big Ben (See description)/thumbnail.png
Error: no processedImg for Billboard/Billboard Texture(Without inscriptions).png
Error: no processedImg for Billboard_3370/Billboard Texture(Without inscriptions).png
Error: no processedImg for Bird (Animal Symbol)/thumbnail.png
Error: no processedImg for Boat (minimalist)/thumbnail.png
Error: no processedImg for Book (Blue)/thumbnail.png
Error: no processedImg for Book (Red)/thumbnail.png
Error: no processedImg for Book (Yellow)/thumbnail.png
Error: no processedImg for Butter Robot (Rick and Morty)/thumbnail.png
Error: no processedImg for Camp Site (remixed)/thumbnail.png
Error: no processedImg for Cat/Tileable-metal-scratch-rust-texture-(14)-nen.jpg
Error: no processedImg for Catapult (siege)/thumbnail.png
Error: no processedImg for Cave (Part 1 of 3)/thumbnail.png
Error: no processedImg for cellule/carnet croquis (15).jpg
Error: no processedImg for cellule/carnet croquis (6).jpg
Error: no processedImg for celouie surfacer/centre de coalition (1).jpg
Error: no processedImg for celouie surfacer/centre de coalition (2).jpg
Error: no processedImg for Circle of Life (GOLD)/GOLD_Circle_of_life_default_color.png
Error: no processedImg for Circle of Life (GOLD)/thumbnail.png
Error: no processedImg for City Block (wip)/thumbnail.png
Error: no processedImg for City in VR (circular)/thumbnail.png
Error: no processedImg for City Landscape (Unfinished)/thumbnail.png
Error: no processedImg for Clock Icon (Simple)/thumbnail.png
Error: no processedImg for Deco photos/rama derevo (1).jpg
Error: no processedImg for defence cannon/turet canon tau (1).jpg
Error: no processedImg for defence cannon/turet canon tau (2).jpg
Error: no processedImg for Dog (Animal Symbol)/thumbnail.png
Error: no processedImg for Drawer (Dresser)/thumbnail.png
Error: no processedImg for Drossel (Disney´s Drossel)/thumbnail.png
Error: no processedImg for Drum Machine (without stand)/thumbnail.png
Error: no processedImg for firebase/FIREBASE tau (2).jpg
Error: no processedImg for firebase/FIREBASE tau (1).jpg
Error: no processedImg for firebase/FIREBASE tau (3).jpg
Error: no processedImg for Floating Island (in progress)/thumbnail.png
Error: no processedImg for Getting ready (Mirror alt)/thumbnail.png
Error: no processedImg for girl/1751db30-(1)-nen.jpg
Error: no processedImg for girl/17b596f0 (1) nen.jpg
Error: no processedImg for Great Tit (small bird)/thumbnail.png
Error: no processedImg for Green Tea Set (Matcha)/thumbnail.png
Error: no processedImg for Guan Yu Shrine (Klong San)/thumbnail.png
Error: no processedImg for Guilmon Blocks (Almost Done)/thumbnail.png
Error: no processedImg for Harbor Princess/g (24)3.png
Error: no processedImg for HELPY Model R1 (QuantizedVR)/thumbnail.png
Error: no processedImg for Hog (Animal Symbol)/thumbnail.png
Error: no processedImg for Horse (Animal Symbol)/thumbnail.png
Error: no processedImg for Hover Battler Sparrow (v.2)/thumbnail.png
Error: no processedImg for Japanese Abacus (Soroban)/thumbnail.png
Error: no processedImg for javascriptalert(1)/Spinnen_Bein_tex.jpg
Error: no processedImg for javascriptalert(1)/SH3.png
Error: no processedImg for javascriptalert(1)/thumbnail.png
Error: no processedImg for javascriptalert(1)/Spinnen_Bein_tex_2.jpg
Error: no processedImg for javascriptalert(1)_1699/SH3.png
Error: no processedImg for javascriptalert(1)_1699/Spinnen_Bein_tex.jpg
Error: no processedImg for javascriptalert(1)_1699/Spinnen_Bein_tex_2.jpg
Error: no processedImg for javascriptalert(1)_1699/thumbnail.png
Error: no processedImg for Long board (Skateboard)/thumbnail.png
Error: no processedImg for Metro Train Prototype (CDMX)/GridBox_Default.png
Error: no processedImg for Metro Train Prototype (CDMX)/thumbnail.png
Error: no processedImg for Mexico City Metro (CDMX)/GridBox_Default.png
Error: no processedImg for Mexico City Metro (CDMX)/thumbnail.png
Error: no processedImg for Monkey (Animal Symbol)/thumbnail.png
Error: no processedImg for Painting/rice-oryza-sativa-asian-hand-260nw-547172458 (2).jpg
Error: no processedImg for pc monka/Pc monka (1).jpg
Error: no processedImg for pc monka/Pc monka (2).jpg
Error: no processedImg for pinball fx3 aliens table/maxresdefault (1).jpg
Error: no processedImg for plasma generator/plasma generator tau- (1).jpg
Error: no processedImg for plasma generator/plasma generator tau- (2).jpg
Error: no processedImg for Rabbit (Animal Symbol)/thumbnail.png
Error: no processedImg for Rabbit (Animal Symbol)_4696/thumbnail.png
Error: no processedImg for Rave's Arm - Gen 2A (WIP)/thumbnail.png
Error: no processedImg for Recorder (musical instrument)/texture.jpg
Error: no processedImg for Recorder (musical instrument)/thumbnail.png
Error: no processedImg for Remixed X-Fighter Model (Flat)/thumbnail.png
Error: no processedImg for Saucer-Shaped Ship (prev. UFO)/thumbnail.png
Error: no processedImg for SD Voltron (GoLion)/thumbnail.png
Error: no processedImg for Self Portrait (Attempt 2)/thumbnail.png
Error: no processedImg for Sheep (Animal Symbol)/thumbnail.png
Error: no processedImg for Snake (Animal Symbol)/thumbnail.png
Error: no processedImg for Space Ship (art)/thumbnail.png
Error: no processedImg for Spaceship (crude)/thumbnail.png
Error: no processedImg for STAR CRUISER (copy)/thumbnail.png
Error: no processedImg for Stool/Tileable-metal-scratch-rust-texture-(14)-1.jpg
Error: no processedImg for Stool/Tileable-metal-scratch-rust-texture-(14)-2.jpg
Error: no processedImg for Stool/Tileable-metal-scratch-rust-texture-(14).jpg
Error: no processedImg for Tak Game (5x5)/thumbnail.png
Error: no processedImg for TIME HOTEL (text)/thumbnail.png
Error: no processedImg for Time Hotel 5.02 (Sneaker)/thumbnail.png
Error: no processedImg for Time Hotel 5.05 (Alexa)/thumbnail.png
Error: no processedImg for Time Hotel 5.11 (Rose)/thumbnail.png
Error: no processedImg for Time Hotel 5.03 (Tracker Ring)/thumbnail.png
Error: no processedImg for Time Hotel 5.16 (Coffee Pot)/thumbnail.png
Error: no processedImg for Time Hotel 5.16 (Coffee)/thumbnail.png
Error: no processedImg for Time Hotel 5.17 (Trowel)/thumbnail.png
Error: no processedImg for Time Hotel 5.18 (Creamer)/thumbnail.png
Error: no processedImg for Time Hotel 5.19 (Slippers)/thumbnail.png
Error: no processedImg for Time Hotel 5.21 (Basket)/thumbnail.png
Error: no processedImg for Time Hotel 5.20 (ID Card)/thumbnail.png
Error: no processedImg for Time Hotel 5.22 (Card Reader)/thumbnail.png
Error: no processedImg for Time Hotel 5.26 (Light Bulb)/thumbnail.png
Error: no processedImg for Time Hotel 5.28 (Pad of Paper)/thumbnail.png
Error: no processedImg for Time Hotel 5.30 (Stop Sign)/thumbnail.png
Error: no processedImg for Time Hotel 7.01 (Suitcase)/thumbnail.png
Error: no processedImg for Time Hotel 7.03 (Car Scraper)/thumbnail.png
Error: no processedImg for Time Hotel 7.04 (Car)/thumbnail.png
Error: no processedImg for Time Hotel Object 5.07 (Knife)/thumbnail.png
Error: no processedImg for Tines (A Fire Upon the Deep)/thumbnail.png
Error: no processedImg for Tiny Mech (Chris Ross Remix)/thumbnail.png
Error: no processedImg for Tower of madness (revised)/thumbnail.png
Error: no processedImg for Tree/Tileable-metal-scratch-rust-texture-(14).jpg
Error: no processedImg for tree(with an ice cream)/thumbnail.png
Error: no processedImg for tree_4830/Tileable-metal-scratch-rust-texture-(14).jpg
Error: no processedImg for Wikiplanet Space Station (WSS)/thumbnail.png
Error: no processedImg for Wood Barrel (Low Poly)/thumbnail.png
Error: no processedImg for Wood Wheel (Low Poly)/thumbnail.png
Error: no processedImg for X-Fighter Remix ( One sided )/thumbnail.png
Error: no processedImg for xyz/BEYAZ (Base Color).png
Error: no processedImg for xyz/BEYAZ (Metallic Roughness).png
Error: no processedImg for xyz/KOYUGRI (Base Color).png
Error: no processedImg for xyz/KOYUGRI (Metallic Roughness).png
Error: no processedImg for xyz/pembe (Base Color).png
Error: no processedImg for xyz/pembe (Metallic Roughness).png
Error: no processedImg for xyz/siyah (Base Color).png
Error: no processedImg for xyz/siyah (Metallic Roughness).png

I originally thought it was paths containing (xx) but there is Bad Boy)))/thumbnail.png which as no ( character. Unfortunately stripping the ) characters from the paths is not an option for me as the paths are referenced inside .gltf files as textures.

Note there is no error thrown by imagemin, it simply does not return any data - the processedImg variable is an empty array [].

Using package versions:

    "imagemin": "^8.0.0",
    "imagemin-jpegtran": "^7.0.0",
    "imagemin-optipng": "^8.0.0",
@looeee
Copy link
Author

looeee commented May 23, 2021

The workaround I found for this is to read the file using fs and pass the result to imagemin.buffer:

const imageBuf = await fs.readFile(inFile)

const processedBuf = await imagemin.buffer(imageBuf, { plugins });

await fs.writeFile(outFile, processedBuf )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@looeee