Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak on js frontend benchmark #892

Open
me7 opened this issue May 8, 2024 · 0 comments
Open

Memory leak on js frontend benchmark #892

me7 opened this issue May 8, 2024 · 0 comments
Labels

Comments

@me7
Copy link

me7 commented May 8, 2024

Description

according to https://github.com/krausest/js-framework-benchmark which have imba version 1.5 implementation at https://github.com/krausest/js-framework-benchmark/blob/master/frameworks/keyed/imba/src/main.imba

I want to update it's benchmark to imba version 2 to submit the updated version

what i found is it's have memory leak, when click "clear row" button on version 1 memory is reduce but v2 memory is same. even clear row code is same with v1 and v2

version 1
image

version 2
image

i create repo of v2 here https://github.com/me7/jsbench-imba-v2 for reproduce the bug

Reproduction

https://github.com/me7/jsbench-imba-v2

System Environment

System:
    OS: Windows 11 10.0.22000
    CPU: (8) x64 AMD Ryzen 7 3750H with Radeon Vega Mobile Gfx
    Memory: 15.70 GB / 21.94 GB
  Binaries:
    Node: 20.10.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.4 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 8.3.0 - C:\Program Files\nodejs\npm.CMD
    pnpm: 9.1.0 - ~\AppData\Local\pnpm\pnpm.CMD
    bun: 1.1.5 - ~\AppData\Roaming\npm\bun.CMD
  Browsers:
    Chrome: 124.0.6367.119
    Edge: Spartan (44.22000.120.0), Chromium (123.0.2420.65)
    Internet Explorer: 11.0.22000.120
  npmPackages:
    imba: * => 2.0.0-alpha.235
@me7 me7 added the bug label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant