Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to report source image errors #1283

Open
koenpunt opened this issue May 3, 2024 · 4 comments
Open

Option to report source image errors #1283

koenpunt opened this issue May 3, 2024 · 4 comments

Comments

@koenpunt
Copy link
Contributor

koenpunt commented May 3, 2024

Apart from reporting unexpected and download errors, it would be useful to have an option to get reports when a source image exceeds for example the "max source resolution".

Would you accept a PR for an additional option for this?

@DarthSim
Copy link
Member

DarthSim commented May 7, 2024

Image format and resolution checks are a part of the downloading flow, so these errors are reported if IMGPROXY_REPORT_DOWNLOADING_ERRORS is set to true.

@koenpunt
Copy link
Contributor Author

koenpunt commented May 7, 2024

Hm that's weird, because we have that option enabled but we're not getting those reported in sentry. The only error we've seen was one for using an invalid path.
I'll check again tomorrow.

@koenpunt
Copy link
Contributor Author

koenpunt commented May 19, 2024

To get back at this; what could be a cause for "Can't download source image: Source image resolution is too big" errors not being reported (to Sentry), when other errors are?

image

@koenpunt
Copy link
Contributor Author

koenpunt commented May 19, 2024

Could it be because the resolution error is reported with the severity of warning instead of error?

{"client_ip":"x.x.x.x","error":"Can't download source image: Source image resolution is too big","message":"Completed in 55.089129ms /_/plain/tmp-koen/cloud.jpg?","method":"GET","request_id":"_QWMwXkE1T9SmXPld3dTk","severity":"warning","status":422,"time":"2024-05-19T21:11:48Z"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants