Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for external IDs when using S3 with assumed roles #1289

Closed
riyadhalnur opened this issue May 13, 2024 · 3 comments · Fixed by #1290
Closed

Support for external IDs when using S3 with assumed roles #1289

riyadhalnur opened this issue May 13, 2024 · 3 comments · Fixed by #1290

Comments

@riyadhalnur
Copy link
Contributor

Currently, imgproxy does not support passing in an external ID when assuming a role for S3 backends. The external ID provides an extra layer of security. The change itself is pretty straight forward. If interested, I can open a PR to add this functionality in.
@riyadhalnur riyadhalnur changed the title Support for external ID when using S3 with assumed roles Support for external IDs when using S3 with assumed roles May 13, 2024
@DarthSim
Copy link
Member

Hey @riyadhalnur!

Sure, PRs are always better than issues and are always welcome 🙂

@riyadhalnur riyadhalnur mentioned this issue May 16, 2024
Merged
@riyadhalnur
Copy link
Contributor Author

PR opened for this

@riyadhalnur riyadhalnur mentioned this issue May 17, 2024
Merged
@riyadhalnur
Copy link
Contributor Author

Corresponding documentation PR - imgproxy/imgproxy-docs#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for passing in an external ID when using S3 assume role riyadhalnur/imgproxy
2 participants
@DarthSim @riyadhalnur