Add support for passing in an external ID when using S3 assume role #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @riyadhalnur! Thanks for the contribution! Everything looks good, but I doubt we need that warning in |
|
I don't mind removing the warning. It's personally helpful for me though because sometimes it happens where I pass in a dependent config but forget about the required configs. |
|
In this case, the role assuming will simply not work and you'll notice this anyway 🙂 |
riyadhalnur
force-pushed
the
feat/s3-assume-role-external-id
branch
from
313d415
to
2e6cfdb
Compare
|
Fair enough. Removed the warning log. I'll create a PR in the docs repo soon for this change. |
|
Merged! Thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1289