Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix draft type for mixed property value types #1014

Merged
merged 2 commits into from Jan 16, 2023

Conversation

Methuselah96
Copy link
Contributor

Fixes #1013.

This PR reverts #990 and adds a test that would fail without these changes to demonstrate the issue.

@coveralls
Copy link

coveralls commented Jan 16, 2023

Pull Request Test Coverage Report for Build 3931453849

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.282%

Totals Coverage Status
Change from base Build 3925165323: 0.0%
Covered Lines: 790
Relevant Lines: 801

💛 - Coveralls

@mweststrate mweststrate merged commit 3eeb331 into immerjs:main Jan 16, 2023
@mweststrate
Copy link
Collaborator

Thanks for the PR! Releasing

@Methuselah96
Copy link
Contributor Author

@mweststrate Can you release this when you get a chance? The latest version on npm still has the broken types.

@mweststrate
Copy link
Collaborator

Apologies! the release should have gone out automatically

@Methuselah96
Copy link
Contributor Author

No problem, thanks for taking a look.

@github-actions
Copy link
Contributor

🎉 This PR is included in version 9.0.19 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mweststrate
Copy link
Collaborator

The release process has been fixed, should be available as 9.0.19 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Draft type no longer handles nested readonly objects with mixed property value types correctly
3 participants