Producer error with nested used on an array member of the substate

[gentilboulet]

🐛 Bug Report

Updating an array in a substate produces an unusable object : reusing the produced object results in an error about proxy.

Link to repro

See tests in : https://codesandbox.io/s/minimal-repro-p6r9s

(Note : codesandbox typescript version is 3.6.2, resulting in warnings with Draft<> for immer 5.3.2)

To Reproduce

function initialStateFactory(): IStoreState {
  return {
    substate: {
      array: [{ id: "id1", value: 0 }, { id: "id2", value: 0 }]
    },
    array: [{ id: "id1", value: 0 }, { id: "id2", value: 0 }]
  };
}

export const globalProducer = produce((draft: Draft<IStoreState>) => {
  draft.substate = subProducer(draft.substate);
  draft.array = arrayProducer(draft.array);
}, initialStateFactory());

const subProducer = produce((draftSubState: Draft<{ array: TArray }>) => {
  draftSubState.array = arrayProducer(draftSubState.array);
});

const arrayProducer = produce((draftArray: Draft<TArray>) => {
  draftArray[0].value += 5;
});

Observed behavior

Applying an array producer on a third level depth produces an invalid state.

On the codesandbox repro, the arrayProducer is used at second and third level depth.
On state.array, it produces the expected result.
When applied on state.substate.array, the produced array is broken.

• Accessing the produced array show the following error, rendering it unusable :
  Cannot perform 'get' on a proxy that has been revoked
• the modified element is still correctly modified
• the array length is still 2
• the second array element seems to be null in console

Expected behavior

Producers should work without issues when nested.

Environment

Was working fine in old code (1.X).
Brokes when updating immer to 5.X.
Seems to works in codesandbox up to 4.0.0-beta.0

• Immer version: 5.3.2
• Occurs with setUseProxies(true)
• Occurs with setUseProxies(false) (ES5 only)

[mweststrate]

Will be fixed in 5.3.3

[aleclarson]

🎉 This issue has been resolved in version 5.3.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀