Error when rebuilding Date with patches

[jgrenon]

Report

When using new Date as a field value in a draft, the resulting patch doesn't produce a valid date when replayed.

Link to repro

https://codesandbox.io/s/immer-sandbox-forked-wzvm6?file=/src/index.js

To Reproduce

Run the code above and look in the console.

Observed behavior

After patch is applied, date is null.

Expected behavior

After patch, date should be a valid primitive date

Environment

Node.JS 14.8.0
Immer 7.0.9

[ebataille]

I got a bug too here, but don't have the same problem,

Wehn I applyPatches with date, and then do a date.getDate, I Have
this is not a date object

I found where the issue happen in Patches.ts in the function deepClonePatchValue

const cloned = Object.create(Object.getPrototypeOf(obj))

should be

const cloned = obj instanceof Date ? new Date(obj) : Object.create(Object.getPrototypeOf(obj))

It solved the issue for me

[mweststrate]

Looks like the deepClonePatchValue misses a pre-condition if (!isDraftable(obj)) return obj

[ebataille]

Any idea of a workaround while this bug is fix ?

[mweststrate]

Opening a PR or patch-package

…

On Wed, 7 Oct 2020, 16:46 Edouard, ***@***.***> wrote: Any idea of a workaround while this bug is fix ? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#676 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAN4NBG6AILFTBHDHJTOVDLSJSEPHANCNFSM4RXPSTLA> .

[mweststrate]

Should be fixed in 7.12

[aleclarson]

🎉 This issue has been resolved in version 7.0.12 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀