Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): sync issue when delete remotes assets #9479

Merged
merged 1 commit into from
May 14, 2024
Merged

fix(server): sync issue when delete remotes assets #9479

merged 1 commit into from
May 14, 2024

Conversation

alextran1502
Copy link
Contributor

@alextran1502 alextran1502 commented May 14, 2024 •
edited

Fixes #9412
Fixes #9471

Expected interfaces

export class AuditDeletesResponseDto {
  needsFullSync!: boolean;
  ids!: string[];
}



export class AssetDeltaSyncResponseDto {
  needsFullSync!: boolean;
  upserted!: AssetResponseDto[];
  deleted!: string[];
}

Before
Screenshot from 2024-05-14 11-12-19

After
Screenshot from 2024-05-14 11-12-31

cc @fyfrey FYI, you cannot trust typeORM in this case to correctly parse the select statement, I know it is weird 😢

@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented May 14, 2024 •
edited

Deploying immich with  Cloudflare Pages  Cloudflare Pages

Latest commit: 57b296c
Status: ✅  Deploy successful!
Preview URL: https://698a2a41.immich.pages.dev
Branch Preview URL: https://hotfix-delete-sync-issue.immich.pages.dev

View logs

@alextran1502 alextran1502 merged commit f28b4e7 into main May 14, 2024
24 of 25 checks passed
@alextran1502 alextran1502 deleted the hotfix/delete-sync-issue branch May 14, 2024 16:51
@alextran1502 alextran1502 mentioned this pull request May 14, 2024
Closed
3 tasks
@fyfrey
Copy link
Contributor

fyfrey commented May 14, 2024

How I hate languages that are not properly typed and checked at compile time xD
Good to know anyhow that getRawMany has limited use...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zackpollard zackpollard zackpollard approved these changes

@jrasm91 jrasm91 jrasm91 approved these changes

@danieldietzler danieldietzler danieldietzler approved these changes

Assignees
No one assigned
Labels
🗄️server
Projects
None yet
Milestone
No milestone
5 participants
@alextran1502 @fyfrey @zackpollard @jrasm91 @danieldietzler