fix(web): new feature photo #9443
Conversation
martabal
force-pushed
the
fix/new-feature-photo
branch
from
fe30b08
to
f44a78e
Compare
Deploying immich with
|
| Latest commit: |
b7ed1bc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4fd79f45.immich.pages.dev |
| Branch Preview URL: | https://fix-new-feature-photo.immich.pages.dev |
| @@ -433,6 +436,7 @@ | |||
| {#each showPeople as person, index (person.id)} | |||
| <PeopleCard | |||
| {person} | |||
| {now} | |||
There was a problem hiding this comment.
Making this a props of the component that must be passed down from the parent component seems strange. Can we isolate this logic in the people-card component itself?
There was a problem hiding this comment.
I tried at first, but if you search for a person and then go back to the full list, you won't use the cached thumbnails
There was a problem hiding this comment.
This basically is equivalent to not using a cache to begin with, which is not ideal. We just need to reload the one image if/when it changes on the parent page. If you make a fetch request for it in the other component, will that refresh the cache so it is updated by the time you navigate here?
There was a problem hiding this comment.
now in:
+page.svelte |
people-card |
|---|---|
2024-05-13.23-20-02.mp4 |
2024-05-13.23-19-39.mp4 |
It's hard to see in a video, but when thumbnails are not cached it's not smooth
There was a problem hiding this comment.
This basically is equivalent to not using a cache to begin with, which is not ideal. We just need to reload the one image if/when it changes on the parent page. If you make a fetch request for it in the other component, will that refresh the cache so it is updated by the time you navigate here?
let me try
There was a problem hiding this comment.
From my testing, the only way to force the new feature photo to update is to change its thumbnail path (because the image source hasn't changed). So the solution requires a lot more changes (probably adding a new query parameter, parsing its value, updating thumbnailPath...?)
martabal
force-pushed
the
fix/new-feature-photo
branch
from
f44a78e
to
b7ed1bc
Compare
fixes #9437.
Currently, if you edit the main photo and return to the /people page, the thumbnails displayed are the previous cached ones. This PR changes the behavior to always force the browser to fetch the latest thumbnails when the /people page is loaded