Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve tests for scandir.go #25

Open
nbari opened this issue Sep 28, 2017 · 2 comments
Open

improve tests for scandir.go #25

nbari opened this issue Sep 28, 2017 · 2 comments

Comments

@nbari
Copy link
Member

nbari commented Sep 28, 2017

improve tests for scandir.go and watchdir.go mainly the onew using kqueue (freebsd netbsd openbsd dragonfly darwin)

func (s *ScanDir) Start(ctl Control) {}

and

func (s *ScanDir) Scandir(ctl Control) error {}
@yogesh-desai
Copy link
Contributor

Hi @nbari
Could you please explain more about it? Specifically, what you mean by,

mainly the onew using kqueue (freebsd netbsd openbsd dragonfly darwin)

@nbari
Copy link
Member Author

nbari commented Oct 8, 2019

It probably helps to mention that kqueue is not available in Linux therefore for BSD systems the tests need to be improved.

For example if you are in mac, after cloning the repo type make cover (you may need make get before). That will open a browser and show the overall coverage in where you will notice that scandir.go and watchdir.go need some improvements/refactoring in order to improve the tests/coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants