Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to clap3 #395

Closed
rinon opened this issue May 10, 2022 · 6 comments · Fixed by #777
Closed

Update to clap3 #395

rinon opened this issue May 10, 2022 · 6 comments · Fixed by #777
Assignees
@thedataking
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rinon
Copy link
Contributor

rinon commented May 10, 2022

Clap3 deprecated YAML support, so we need to rewrite command-line parsing to use the new APIs.
@rinon rinon added the good first issue Good for newcomers label May 10, 2022
rinon added a commit that referenced this issue May 10, 2022
@rinon
Update all dependencies to latest version
60750cc 
Updates all C2Rust dependency crates except clap to their latest
version. Some features we use were deprecated, but that can be addressed
in future followups. Clap3 removed YAML support, so we need to do a
significant rewrite of command-line parsing to update to the new
version (issue #395).
rinon added a commit that referenced this issue May 10, 2022
@rinon
Update all dependencies to latest version
dbfcde6 
Updates all C2Rust dependency crates except clap to their latest
version. Some features we use were deprecated, but that can be addressed
in future followups. Clap3 removed YAML support, so we need to do a
significant rewrite of command-line parsing to update to the new
version (issue #395).
rinon added a commit that referenced this issue May 11, 2022
@rinon
Update all dependencies to latest version
244cc5a 
Updates all C2Rust dependency crates except clap to their latest
version. Some features we use were deprecated, but that can be addressed
in future followups. Clap3 removed YAML support, so we need to do a
significant rewrite of command-line parsing to update to the new
version (issue #395).
rinon added a commit that referenced this issue May 11, 2022
@rinon
Update all dependencies to latest version
5a0976a 
Updates all C2Rust dependency crates except clap to their latest
version. Some features we use were deprecated, but that can be addressed
in future followups. Clap3 removed YAML support, so we need to do a
significant rewrite of command-line parsing to update to the new
version (issue #395).
rinon added a commit that referenced this issue May 12, 2022
@rinon
Update all dependencies to latest version
5dcc6bd 
Updates all C2Rust dependency crates except clap to their latest
version. Some features we use were deprecated, but that can be addressed
in future followups. Clap3 removed YAML support, so we need to do a
significant rewrite of command-line parsing to update to the new
version (issue #395).
rinon added a commit that referenced this issue May 12, 2022
@rinon
Update all dependencies to latest version
2ee2c42 
Updates all C2Rust dependency crates except clap to their latest
version. Some features we use were deprecated, but that can be addressed
in future followups. Clap3 removed YAML support, so we need to do a
significant rewrite of command-line parsing to update to the new
version (issue #395).
@kkysen kkysen added the enhancement New feature or request label Jun 17, 2022
This was referenced Jul 1, 2022
Open
Merged
@kkysen kkysen mentioned this issue Jul 22, 2022
Merged
@marcograss marcograss mentioned this issue Oct 13, 2022
Closed
@kkysen
Copy link
Contributor

kkysen commented Oct 13, 2022

Did clap 3 actually deprecate yaml support? #702 suggests it didn't, and from clap's documentation (v3 and v4) it seems like yaml is still supported. If that's the case, then we can just upgrade clap to 3 and even 4 without changes. I think using the derive API is a lot cleaner and type-safe, but that can be done separately from updating the clap dependency.

@rinon
Copy link
Contributor Author

rinon commented Oct 13, 2022

deprecated != removed (clap-rs/clap#3087). This is very low priority though.

@kkysen
Copy link
Contributor

kkysen commented Oct 13, 2022

Ah, okay. I missed that. Though can't we still upgrade to clap 3, though, so we only have one clap version and faster builds. Then leave this issue for moving away from the yaml API? I get that it's not very important, though, but #702 was trying to do it but without removing the yaml.

@marcograss
Copy link
Contributor

#703 now

@bytewife bytewife mentioned this issue Jan 13, 2023
Merged
@fw-immunant
Copy link
Contributor

Fixed by #703.

@kkysen
Copy link
Contributor

kkysen commented Jan 26, 2023

Not really fixed by #703. Actually will be fixed by #777, so we'll close this when that merges.

@kkysen kkysen reopened this Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thedataking thedataking

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update c2rust-transpile to use clap 3's derive API bytewife/c2rust
5 participants
@rinon @marcograss @thedataking @kkysen @fw-immunant