Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make VavrMapEncoding consistent with immutables naming #24

Open
dudkiewicz-codes opened this issue Jan 14, 2020 · 1 comment
Open

Make VavrMapEncoding consistent with immutables naming #24

dudkiewicz-codes opened this issue Jan 14, 2020 · 1 comment

Comments

@dudkiewicz-codes
Copy link

VavrMapEncoding adds Entry prefix for tuple related operations.
Current solution has some drawbacks:

  • it isn't configurable
  • it isn't consistent with immutables encoding ( it generates putBar(Map.Entry<? extends K, ? extends V>) method )
  • matter of taste, but in my opinion "Entry" doesn't add any value and makes builder too verbose

How about replacing:

@Encoding.Naming(value = "putEntry*", depluralize = true)
with
@Encoding.Naming(standard = Encoding.StandardNaming.PUT)

@Encoding.Naming(value = "setEntries*")
with
@Encoding.Naming(standard = Encoding.StandardNaming.PUT_ALL)
?

Also, I would consider replacing
@Encoding.Naming(value = "setJavaMap*")
with
@Encoding.Naming(standard = Encoding.StandardNaming.PUT_ALL)

@io7m
Copy link
Member

io7m commented Jan 14, 2020

I'm open to patches for this, if you have them! I've had very little time to work on this project lately. 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants