Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

value-fixture contains version 61 .class files (should be version 52) (2.10.0) #1486

Open
snazy opened this issue Oct 9, 2023 · 3 comments

Comments

@snazy
Copy link
Contributor

snazy commented Oct 9, 2023

Builds that use org.immutables:value-fixture and run with/for Java 11 or 8 fail with immutables v2.10.0.

The class files in value-fixture-2.10.0.jar are all compiled for Java 17 (class file version 61). I suspect, the class files should be compiled for Java 8 as documented ("... use @Nullable, @AllowNulls, @SkipNulls as Java 8 type annotation...").

Immutables 2.9.3 was fine.

snazy added a commit to projectnessie/nessie that referenced this issue Oct 9, 2023
renovate bot added a commit to projectnessie/nessie that referenced this issue Oct 9, 2023
* Update immutables to v2.10.0

* Use old `value-fixture` (see immutables/immutables#1486)

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Robert Stupp <snazy@snazy.de>
@elucash
Copy link
Member

elucash commented Oct 11, 2023

is it a problem with "value-fixture" only? or other modules are affected. If this is only "value-fixture", then it can be fixed (haven't looked in those profiles in a while), but should not an issue as this is test-only module, hope no one is really using it.

@snazy
Copy link
Contributor Author

snazy commented Oct 11, 2023

Yes, only that artifact is affected.
Sadly, that artifact is required to use the @AllowNulls + @SkipNulls annotations.

@elucash
Copy link
Member

elucash commented Oct 15, 2023

Thats not true, this is test only artifact, noone should include it code. Those annotations you mention should be your own, create them or copy paste in your package. These annotations are bring-your-own-annotations so only simple name should match!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants