/
no-cycle.js
257 lines (245 loc) · 9.22 KB
/
no-cycle.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
import { parsers, test as _test, testFilePath, testVersion as _testVersion } from '../utils';
import { RuleTester } from 'eslint';
import flatMap from 'array.prototype.flatmap';
const ruleTester = new RuleTester();
const rule = require('rules/no-cycle');
const error = message => ({ message });
const test = def => _test(Object.assign(def, {
filename: testFilePath('./cycles/depth-zero.js'),
}));
const testVersion = (specifier, t) => _testVersion(specifier, () => Object.assign(t(), {
filename: testFilePath('./cycles/depth-zero.js'),
}));
const testDialects = ['es6'];
ruleTester.run('no-cycle', rule, {
valid: [].concat(
// this rule doesn't care if the cycle length is 0
test({ code: 'import foo from "./foo.js"' }),
test({ code: 'import _ from "lodash"' }),
test({ code: 'import foo from "@scope/foo"' }),
test({ code: 'var _ = require("lodash")' }),
test({ code: 'var find = require("lodash.find")' }),
test({ code: 'var foo = require("./foo")' }),
test({ code: 'var foo = require("../foo")' }),
test({ code: 'var foo = require("foo")' }),
test({ code: 'var foo = require("./")' }),
test({ code: 'var foo = require("@scope/foo")' }),
test({ code: 'var bar = require("./bar/index")' }),
test({ code: 'var bar = require("./bar")' }),
test({
code: 'var bar = require("./bar")',
filename: '<text>',
}),
test({
code: 'import { foo } from "cycles/external/depth-one"',
options: [{ ignoreExternal: true }],
settings: {
'import/resolver': 'webpack',
'import/external-module-folders': ['cycles/external'],
},
}),
test({
code: 'import { foo } from "./external-depth-two"',
options: [{ ignoreExternal: true }],
settings: {
'import/resolver': 'webpack',
'import/external-module-folders': ['cycles/external'],
},
}),
flatMap(testDialects, (testDialect) => [
test({
code: `import { foo } from "./${testDialect}/depth-two"`,
options: [{ maxDepth: 1 }],
}),
test({
code: `import { foo, bar } from "./${testDialect}/depth-two"`,
options: [{ maxDepth: 1 }],
}),
test({
code: `import("./${testDialect}/depth-two").then(function({ foo }) {})`,
options: [{ maxDepth: 1 }],
parser: parsers.BABEL_OLD,
}),
test({
code: `import type { FooType } from "./${testDialect}/depth-one"`,
parser: parsers.BABEL_OLD,
}),
test({
code: `import type { FooType, BarType } from "./${testDialect}/depth-one"`,
parser: parsers.BABEL_OLD,
}),
test({
code: `function bar(){ return import("./${testDialect}/depth-one"); } // #2265 1`,
options: [{ allowUnsafeDynamicCyclicDependency: true }],
parser: parsers.BABEL_OLD,
}),
test({
code: `import { foo } from "./${testDialect}/depth-one-dynamic"; // #2265 2`,
options: [{ allowUnsafeDynamicCyclicDependency: true }],
parser: parsers.BABEL_OLD,
}),
].concat(parsers.TS_NEW ? [
test({
code: `function bar(){ return import("./${testDialect}/depth-one"); } // #2265 3`,
options: [{ allowUnsafeDynamicCyclicDependency: true }],
parser: parsers.TS_NEW,
}),
test({
code: `import { foo } from "./${testDialect}/depth-one-dynamic"; // #2265 4`,
options: [{ allowUnsafeDynamicCyclicDependency: true }],
parser: parsers.TS_NEW,
}),
] : [])),
test({
code: 'import { bar } from "./flow-types"',
parser: parsers.BABEL_OLD,
}),
test({
code: 'import { bar } from "./flow-types-only-importing-type"',
parser: parsers.BABEL_OLD,
}),
test({
code: 'import { bar } from "./flow-types-only-importing-multiple-types"',
parser: parsers.BABEL_OLD,
}),
),
invalid: [].concat(
test({
code: 'import { bar } from "./flow-types-some-type-imports"',
parser: parsers.BABEL_OLD,
errors: [error(`Dependency cycle detected.`)],
}),
test({
code: 'import { foo } from "cycles/external/depth-one"',
errors: [error(`Dependency cycle detected.`)],
settings: {
'import/resolver': 'webpack',
'import/external-module-folders': ['cycles/external'],
},
}),
test({
code: 'import { foo } from "./external-depth-two"',
errors: [error(`Dependency cycle via cycles/external/depth-one:1`)],
settings: {
'import/resolver': 'webpack',
'import/external-module-folders': ['cycles/external'],
},
}),
flatMap(testDialects, (testDialect) =>
// Ensure behavior does not change for those tests, with or without `
flatMap([
{},
{ allowUnsafeDynamicCyclicDependency: true },
], (opts) => [
test({
code: `import { foo } from "./${testDialect}/depth-one"`,
options: [{ ...opts }],
errors: [error(`Dependency cycle detected.`)],
}),
test({
code: `import { foo } from "./${testDialect}/depth-one"`,
options: [{ ...opts, maxDepth: 1 }],
errors: [error(`Dependency cycle detected.`)],
}),
test({
code: `const { foo } = require("./${testDialect}/depth-one")`,
errors: [error(`Dependency cycle detected.`)],
options: [{ ...opts, commonjs: true }],
}),
test({
code: `require(["./${testDialect}/depth-one"], d1 => {})`,
errors: [error(`Dependency cycle detected.`)],
options: [{ ...opts, amd: true }],
}),
test({
code: `define(["./${testDialect}/depth-one"], d1 => {})`,
errors: [error(`Dependency cycle detected.`)],
options: [{ ...opts, amd: true }],
}),
test({
code: `import { foo } from "./${testDialect}/depth-two"`,
options: [{ ...opts }],
errors: [error(`Dependency cycle via ./depth-one:1`)],
}),
test({
code: `import { foo } from "./${testDialect}/depth-two"`,
options: [{ ...opts, maxDepth: 2 }],
errors: [error(`Dependency cycle via ./depth-one:1`)],
}),
test({
code: `const { foo } = require("./${testDialect}/depth-two")`,
errors: [error(`Dependency cycle via ./depth-one:1`)],
options: [{ ...opts, commonjs: true }],
}),
test({
code: `import { two } from "./${testDialect}/depth-three-star"`,
options: [{ ...opts }],
errors: [error(`Dependency cycle via ./depth-two:1=>./depth-one:1`)],
}),
test({
code: `import one, { two, three } from "./${testDialect}/depth-three-star"`,
options: [{ ...opts }],
errors: [error(`Dependency cycle via ./depth-two:1=>./depth-one:1`)],
}),
test({
code: `import { bar } from "./${testDialect}/depth-three-indirect"`,
options: [{ ...opts }],
errors: [error(`Dependency cycle via ./depth-two:1=>./depth-one:1`)],
}),
test({
code: `import { bar } from "./${testDialect}/depth-three-indirect"`,
options: [{ ...opts }],
errors: [error(`Dependency cycle via ./depth-two:1=>./depth-one:1`)],
parser: parsers.BABEL_OLD,
}),
test({
code: `import { foo } from "./${testDialect}/depth-two"`,
options: [{ ...opts, maxDepth: Infinity }],
errors: [error(`Dependency cycle via ./depth-one:1`)],
}),
test({
code: `import { foo } from "./${testDialect}/depth-two"`,
options: [{ ...opts, maxDepth: '∞' }],
errors: [error(`Dependency cycle via ./depth-one:1`)],
}),
]).concat([
test({
code: `import("./${testDialect}/depth-three-star")`,
errors: [error(`Dependency cycle via ./depth-two:1=>./depth-one:1`)],
parser: parsers.BABEL_OLD,
}),
test({
code: `import("./${testDialect}/depth-three-indirect")`,
errors: [error(`Dependency cycle via ./depth-two:1=>./depth-one:1`)],
parser: parsers.BABEL_OLD,
}),
test({
code: `function bar(){ return import("./${testDialect}/depth-one"); } // #2265 5`,
errors: [error(`Dependency cycle detected.`)],
parser: parsers.BABEL_OLD,
}),
]).concat(
testVersion('> 3', () => ({ // Dynamic import is not properly caracterized with eslint < 4
code: `import { foo } from "./${testDialect}/depth-one-dynamic"; // #2265 6`,
errors: [error(`Dependency cycle detected.`)],
parser: parsers.BABEL_OLD,
})),
).concat(parsers.TS_NEW ? [
test({
code: `function bar(){ return import("./${testDialect}/depth-one"); } // #2265 7`,
errors: [error(`Dependency cycle detected.`)],
parser: parsers.TS_NEW,
}),
test({
code: `import { foo } from "./${testDialect}/depth-one-dynamic"; // #2265 8`,
errors: [error(`Dependency cycle detected.`)],
parser: parsers.TS_NEW,
}),
] : [])),
test({
code: 'import { bar } from "./flow-types-depth-one"',
parser: parsers.BABEL_OLD,
errors: [error(`Dependency cycle via ./flow-types-depth-two:4=>./es6/depth-one:1`)],
}),
),
});