From 2e72af5a99211d3994dba3465fe2567c9335c150 Mon Sep 17 00:00:00 2001 From: Nick Partridge Date: Fri, 29 May 2020 15:41:05 -0500 Subject: [PATCH] [Docs] `order`: fix bad inline config `alphabetize` option does not permit boolean --- CHANGELOG.md | 11 +++++++---- docs/rules/order.md | 4 ++-- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c6e9ec975..a97d84aa2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -21,6 +21,7 @@ This change log adheres to standards from [Keep a CHANGELOG](http://keepachangel ### Changed - TypeScript config: Disable [`named`][] ([#1726], thanks [@astorije]) - [readme] Remove duplicate no-unused-modules from docs ([#1690], thanks [@arvigeus]) +- [Docs] `order`: fix bad inline config ([#1788], thanks [@nickofthyme]) ## [2.20.2] - 2020-03-28 ### Fixed @@ -676,11 +677,12 @@ for info on changes for earlier releases. [`memo-parser`]: ./memo-parser/README.md -[#1770]: https://github.com/benmosher/eslint-plugin-import/issues/1770 -[#1726]: https://github.com/benmosher/eslint-plugin-import/issues/1726 -[#1724]: https://github.com/benmosher/eslint-plugin-import/issues/1724 +[#1788]: https://github.com/benmosher/eslint-plugin-import/pull/1788 +[#1770]: https://github.com/benmosher/eslint-plugin-import/pull/1770 +[#1726]: https://github.com/benmosher/eslint-plugin-import/pull/1726 +[#1724]: https://github.com/benmosher/eslint-plugin-import/pull/1724 [#1722]: https://github.com/benmosher/eslint-plugin-import/issues/1722 -[#1719]: https://github.com/benmosher/eslint-plugin-import/issues/1719 +[#1719]: https://github.com/benmosher/eslint-plugin-import/pull/1719 [#1702]: https://github.com/benmosher/eslint-plugin-import/issues/1702 [#1690]: https://github.com/benmosher/eslint-plugin-import/pull/1690 [#1681]: https://github.com/benmosher/eslint-plugin-import/pull/1681 @@ -1159,3 +1161,4 @@ for info on changes for earlier releases. [@arvigeus]: https://github.com/arvigeus [@atos1990]: https://github.com/atos1990 [@Hypnosphi]: https://github.com/Hypnosphi +[@nickofthyme]: https://github.com/nickofthyme diff --git a/docs/rules/order.md b/docs/rules/order.md index 667b63374..3aa41bbf5 100644 --- a/docs/rules/order.md +++ b/docs/rules/order.md @@ -229,7 +229,7 @@ alphabetize: { This will fail the rule check: ```js -/* eslint import/order: ["error", {"alphabetize": true}] */ +/* eslint import/order: ["error", {"alphabetize": {"order": "asc", "caseInsensitive": true}}] */ import React, { PureComponent } from 'react'; import aTypes from 'prop-types'; import { compose, apply } from 'xcompose'; @@ -240,7 +240,7 @@ import blist from 'BList'; While this will pass: ```js -/* eslint import/order: ["error", {"alphabetize": true}] */ +/* eslint import/order: ["error", {"alphabetize": {"order": "asc", "caseInsensitive": true}}] */ import blist from 'BList'; import * as classnames from 'classnames'; import aTypes from 'prop-types';