diff --git a/CHANGELOG.md b/CHANGELOG.md index 0c893274e..33f926785 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,11 +12,12 @@ This change log adheres to standards from [Keep a CHANGELOG](http://keepachangel - [`no-extraneous-dependencies`]: Implement support for [bundledDependencies](https://npm.github.io/using-pkgs-docs/package-json/types/bundleddependencies.html) ([#1436], thanks [@schmidsi])) ### Fixed -- `default`: make error message less confusing ([#1470], thanks [@golopot]) +- [`default`]: make error message less confusing ([#1470], thanks [@golopot]) - Improve performance of `ExportMap.for` by only loading paths when necessary. ([#1519], thanks [@brendo]) - Support export of a merged TypeScript namespace declaration ([#1495], thanks [@benmunro]) - [`import/order`]: fix autofix to not move imports across fn calls ([#1253], thanks [@tihonove]) - [`prefer-default-export`]: fix false positive with type export ([#1506], thanks [@golopot]) +- [`extensions`]: Fix `ignorePackages` to produce errors ([#1521], thanks [@saschanaz]) ## [2.18.2] - 2019-07-19 - Skip warning on type interfaces ([#1425], thanks [@lencioni]) @@ -611,6 +612,7 @@ for info on changes for earlier releases. [`memo-parser`]: ./memo-parser/README.md +[#1521]: https://github.com/benmosher/eslint-plugin-import/pull/1521 [#1519]: https://github.com/benmosher/eslint-plugin-import/pull/1519 [#1506]: https://github.com/benmosher/eslint-plugin-import/pull/1506 [#1495]: https://github.com/benmosher/eslint-plugin-import/pull/1495 @@ -1001,3 +1003,4 @@ for info on changes for earlier releases. [@benmunro]: https://github.com/benmunro [@tihonove]: https://github.com/tihonove [@brendo]: https://github.com/brendo +[@saschanaz]: https://github.com/saschanaz diff --git a/src/rules/extensions.js b/src/rules/extensions.js index b72c91bad..0fe605adc 100644 --- a/src/rules/extensions.js +++ b/src/rules/extensions.js @@ -50,6 +50,11 @@ function buildProperties(context) { } }) + if (result.defaultConfig === 'ignorePackages') { + result.defaultConfig = 'always' + result.ignorePackages = true + } + return result } diff --git a/tests/src/rules/extensions.js b/tests/src/rules/extensions.js index d7b97bea0..a1629335c 100644 --- a/tests/src/rules/extensions.js +++ b/tests/src/rules/extensions.js @@ -63,7 +63,7 @@ ruleTester.run('extensions', rule, { code: ` import foo from './foo.js' import bar from './bar.json' - import Component from './Component' + import Component from './Component.jsx' import express from 'express' `, options: [ 'ignorePackages' ], @@ -309,6 +309,28 @@ ruleTester.run('extensions', rule, { ], }), + test({ + code: ` + import foo from './foo.js' + import bar from './bar.json' + import Component from './Component' + import baz from 'foo/baz' + import express from 'express' + `, + options: [ 'ignorePackages' ], + errors: [ + { + message: 'Missing file extension for "./Component"', + line: 4, + column: 31, + }, { + message: 'Missing file extension for "foo/baz"', + line: 5, + column: 25, + }, + ], + }), + test({ code: ` import foo from './foo.js'