diff --git a/src/rules/no-unused-modules.js b/src/rules/no-unused-modules.js index 60416d21c..9d2d91a1b 100644 --- a/src/rules/no-unused-modules.js +++ b/src/rules/no-unused-modules.js @@ -64,7 +64,6 @@ const VARIABLE_DECLARATION = 'VariableDeclaration' const FUNCTION_DECLARATION = 'FunctionDeclaration' const CLASS_DECLARATION = 'ClassDeclaration' const DEFAULT = 'default' -const TYPE_ALIAS = 'TypeAlias' /** * List of imports per file. @@ -563,8 +562,7 @@ module.exports = { if (declaration) { if ( declaration.type === FUNCTION_DECLARATION || - declaration.type === CLASS_DECLARATION || - declaration.type === TYPE_ALIAS + declaration.type === CLASS_DECLARATION ) { newExportIdentifiers.add(declaration.id.name) } @@ -889,8 +887,7 @@ module.exports = { if (node.declaration) { if ( node.declaration.type === FUNCTION_DECLARATION || - node.declaration.type === CLASS_DECLARATION || - node.declaration.type === TYPE_ALIAS + node.declaration.type === CLASS_DECLARATION ) { checkUsage(node, node.declaration.id.name) } diff --git a/tests/files/no-unused-modules/flow-0.js b/tests/files/no-unused-modules/flow-0.js deleted file mode 100644 index 46bda6879..000000000 --- a/tests/files/no-unused-modules/flow-0.js +++ /dev/null @@ -1 +0,0 @@ -import { type FooType } from './flow-2'; diff --git a/tests/files/no-unused-modules/flow-1.js b/tests/files/no-unused-modules/flow-1.js deleted file mode 100644 index bb7266d3c..000000000 --- a/tests/files/no-unused-modules/flow-1.js +++ /dev/null @@ -1,2 +0,0 @@ -// @flow strict -export type Bar = number; diff --git a/tests/files/no-unused-modules/flow-2.js b/tests/files/no-unused-modules/flow-2.js deleted file mode 100644 index 0cbb836a6..000000000 --- a/tests/files/no-unused-modules/flow-2.js +++ /dev/null @@ -1,2 +0,0 @@ -// @flow strict -export type FooType = string; diff --git a/tests/src/rules/no-unused-modules.js b/tests/src/rules/no-unused-modules.js index d409e41ed..a066dd33f 100644 --- a/tests/src/rules/no-unused-modules.js +++ b/tests/src/rules/no-unused-modules.js @@ -680,38 +680,6 @@ describe('do not report unused export for files mentioned in package.json', () = }) }) -describe('correctly report flow types', () => { - ruleTester.run('no-unused-modules', rule, { - valid: [ - test({ - options: unusedExportsOptions, - code: 'import { type FooType } from "./flow-2";', - parser: require.resolve('babel-eslint'), - filename: testFilePath('./no-unused-modules/flow-0.js'), - }), - test({ - options: unusedExportsOptions, - code: `// @flow strict - export type FooType = string;`, - parser: require.resolve('babel-eslint'), - filename: testFilePath('./no-unused-modules/flow-2.js'), - }), - ], - invalid: [ - test({ - options: unusedExportsOptions, - code: `// @flow strict - export type Bar = string;`, - parser: require.resolve('babel-eslint'), - filename: testFilePath('./no-unused-modules/flow-1.js'), - errors: [ - error(`exported declaration 'Bar' not used within other modules`), - ], - }), - ], - }) -}) - describe('Avoid errors if re-export all from umd compiled library', () => { ruleTester.run('no-unused-modules', rule, { valid: [