From ceb5fe125009c14ae0f6b5e68b032799b2dfe157 Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Wed, 10 Nov 2021 14:20:21 -0800 Subject: [PATCH] [Refactor] `no-default-export`: tweak rule --- src/rules/no-default-export.js | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/rules/no-default-export.js b/src/rules/no-default-export.js index cb7c0bb724..bcdca1ccac 100644 --- a/src/rules/no-default-export.js +++ b/src/rules/no-default-export.js @@ -16,9 +16,7 @@ module.exports = { } const preferNamed = 'Prefer named exports.'; - const noAliasDefault = ({ local }) => - `Do not alias \`${local.name}\` as \`default\`. Just export ` + - `\`${local.name}\` itself instead.`; + const noAliasDefault = ({ local }) => `Do not alias \`${local.name}\` as \`default\`. Just export \`${local.name}\` itself instead.`; return { ExportDefaultDeclaration(node) { @@ -26,12 +24,10 @@ module.exports = { }, ExportNamedDeclaration(node) { - node.specifiers.forEach(specifier => { - if (specifier.type === 'ExportDefaultSpecifier' && - specifier.exported.name === 'default') { + node.specifiers.filter(specifier => specifier.exported.name === 'default').forEach(specifier => { + if (specifier.type === 'ExportDefaultSpecifier') { context.report({ node, message: preferNamed }); - } else if (specifier.type === 'ExportSpecifier' && - specifier.exported.name === 'default') { + } else if (specifier.type === 'ExportSpecifier') { context.report({ node, message: noAliasDefault(specifier) }); } });