Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packageDir array support #1176

Merged
merged 3 commits into from
Oct 10, 2018
Merged

Fix packageDir array support #1176

merged 3 commits into from
Oct 10, 2018

Conversation

pzhine
Copy link

@pzhine pzhine commented Sep 29, 2018

Fixes #1175

@coveralls
Copy link

Coverage Status

Coverage increased (+2.9%) to 97.349% when pulling b86020d on pzhine:master into e8954db on benmosher:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+2.9%) to 97.349% when pulling b86020d on pzhine:master into e8954db on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.9%) to 97.349% when pulling b86020d on pzhine:master into e8954db on benmosher:master.

@benmosher
Copy link
Member

looks great! thanks!

@benmosher benmosher merged commit d3a58f8 into import-js:master Oct 10, 2018
@ljharb
Copy link
Member

ljharb commented Oct 11, 2018

@benmosher this was merged while tests were failing, and now master is broken. This needs to be fixed or reverted.

@benmosher
Copy link
Member

yeah, weird. the original commit built fine though. looks like some deep typescript dependency changed and is why the later (markdown-only) builds failed.

@robin-ambachtsheer
Copy link

When will this fix be published?

@afenton90
Copy link

afenton90 commented Dec 21, 2018

Does this issue need picking up again? As it is broken in the current version of master. Happy to re-apply the fix?

My bad can see that this isn't released yet. Is there anything I can help with to get this released?

@benmosher
Copy link
Member

published! v2.15.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants