Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] no-unused-modules: make import { name as otherName } work #1340

Merged
merged 1 commit into from
Apr 21, 2019
Merged

[fix] no-unused-modules: make import { name as otherName } work #1340

merged 1 commit into from
Apr 21, 2019

Conversation

rfermann
Copy link
Contributor

Fixes #1339

ljharb
ljharb approved these changes Apr 21, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks :-)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.983% when pulling 174afbb on rfermann:1339 into 12bbfca on benmosher:master.

@ljharb ljharb merged commit 174afbb into import-js:master Apr 21, 2019
@ehmicky
Copy link

ehmicky commented Apr 21, 2019 •
edited

Thanks for this PR! However I think this might not solve the original issue. See this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] import/no-unused-modules does not work with import { name as otherName }
4 participants
@rfermann @coveralls @ehmicky @ljharb