Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude pkg main files from no-unused-modules #1404

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Exclude pkg main files from no-unused-modules #1404

merged 1 commit into from
Jul 17, 2019

Conversation

rfermann
Copy link
Contributor

@rfermann rfermann commented Jul 2, 2019

Implements a solution for #1327

@coveralls
Copy link

coveralls commented Jul 2, 2019 •
edited

Coverage Status

Coverage increased (+0.03%) to 97.992% when pulling 1caa402 on rfermann:master into 22d5440 on benmosher:master.

ljharb
ljharb requested changes Jul 2, 2019
View reviewed changes
docs/rules/no-unused-modules.md Outdated Show resolved Hide resolved
src/rules/no-unused-modules.js Show resolved Hide resolved
ljharb
ljharb requested changes Jul 15, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great! Just a couple more changes.

docs/rules/no-unused-modules.md Outdated Show resolved Hide resolved
tests/files/no-unused-modules/main/index.js Outdated Show resolved Hide resolved
ljharb
ljharb requested changes Jul 16, 2019
View reviewed changes
src/rules/no-unused-modules.js Outdated Show resolved Hide resolved
@ljharb ljharb force-pushed the master branch 2 times, most recently from ef3b84e to 1caa402 Compare July 17, 2019 21:55
@ljharb ljharb merged commit 1caa402 into import-js:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rfermann @coveralls @ljharb