Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] no-cycles Add failing tests for commonjs imports #1517

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

soryy708
Copy link
Contributor

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.8%) to 93.703% when pulling 78e995f on soryy708:cycles into 112a0bf on benmosher:master.

@soryy708
Copy link
Contributor Author

Coverage decreased by adding tests? Is it accidentally counting tests/files/?

@ljharb ljharb force-pushed the cycles branch 3 times, most recently from 238fb4e to 50ef767 Compare August 8, 2021 19:21
@ljharb
Copy link
Member

ljharb commented Aug 8, 2021

I've rebased this and merged the first commit into master.

@ljharb ljharb changed the title [import/no-cycles] Add tests for commonjs imports [Tests] no-cycles Add failing tests for commonjs imports Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants