Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pathGroups with different behaviour for external and internal groups #1585

Closed
beatriz opened this issue Dec 26, 2019 · 3 comments
Closed

pathGroups with different behaviour for external and internal groups #1585

beatriz opened this issue Dec 26, 2019 · 3 comments

Comments

@beatriz
Copy link

beatriz commented Dec 26, 2019

I am using pathGroups to add some extra layers on the import orders. However, it would be nice for it to have the same behaviour on external and internal groups.

Currently, I have

import React from "react";
import Icon from "antd/lib/Icon";
import Menu from "antd/lib/Menu";

but it would be really nice if I could add

"pathGroups": [
  {
     "pattern": "antd/**",
     "group": "external",
     "position": "after"
  }
]

to force the separation of the antd imports, as they can be many. Is it possible currently? I find it not working.

@ljharb
Copy link
Member

ljharb commented Dec 30, 2019

I believe this is achieved with the pathGroups option, added in #1386 and available in v2.19.0.

@ljharb ljharb closed this as completed Dec 30, 2019
@beatriz
Copy link
Author

beatriz commented Jan 2, 2020

I am using pathGroups already, but my issue is the behaviour for external dependencies isn't the same as for internal dependencies.

@ljharb
Copy link
Member

ljharb commented Jan 2, 2020

aha, my mistake - in that case, I think #1570 will address your issue once released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants