[Fix] no-duplicates: ensure autofix avoids excessive newlines

[ertrzyiks]

Fixes #2027

Each removed import can potentially leave an empty line character. When a module has multiple repeated imports, the output of the autofix includes a gap of empty lines. The number of empty lines are equal to the number of removed imports.

import { One } from '../fragments/one'
import { Two } from '../fragments/two'
import { Three } from '../fragments/three'
import { Four } from '../fragments/four'
import { Five } from '../fragments/five'
import { Six } from '../fragments/six'
import { Seven } from '../fragments/seven'
import { Eight } from '../fragments/eight'
import { TypedDocumentNode as DocumentNode } from '@graphql-typed-document-node/core'
import { OneDoc } from '../fragments/one'
import { TwoDoc } from '../fragments/two'
import { ThreeDoc } from '../fragments/three'
import { FourDoc } from '../fragments/four'
import { FiveDoc } from '../fragments/five'
import { SixDoc } from '../fragments/six'
import { SevenDoc } from '../fragments/seven'
import { EightDoc } from '../fragments/eight'
export const Vars = any

becomes

import { TypedDocumentNode as DocumentNode } from '@graphql-typed-document-node/core'

import { One , OneDoc } from '../fragments/one'
import { Two , TwoDoc } from '../fragments/two'
import { Three , ThreeDoc } from '../fragments/three'
import { Four , FourDoc } from '../fragments/four'
import { Five , FiveDoc } from '../fragments/five'
import { Six , SixDoc } from '../fragments/six'
import { Seven , SevenDoc } from '../fragments/seven'
import { Eight , EightDoc } from '../fragments/eight'








export const Vars = any

Remove a new line character if it's immediately after the removed import.

[coveralls]

Coverage increased (+0.06%) to 82.607% when pulling 7aea664 on ertrzyiks:issue-2027-no-duplicates into 998c300 on benmosher:master.

[ljharb]

@ertrzyiks looks like these are legit failures. Please mark the PR as "ready for review" when you've got them passing (or ping me if you're stuck)

[ertrzyiks]

@ljharb as I mentioned #2027 (comment) it seems to me that the auto-fix would need to be too smart to remove the import in a clean way. The failed examples highlighted issues with leading spaces

  import A from 'a'
  import A from 'a'
  import B from 'b'

Becomes

  import A from 'a'
    import B from 'b'

Because I removed only the new line characters. We could either rewrite tests to not have leading spaces and they will pass, or we can clean all spaces that occur before the import. WDYT?

[ljharb]

hmm, that's a good question.

in this case, since import statements are always at the top level of the module, it doesn't make any sense to have leading spaces before import, so i'd say we can just remove them?

[ertrzyiks]

Alright, I will update the tests and will mark the PR as ready for review once green. Thanks for the feedback @ljharb