Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule no-extraneous-dependencies complains about non-existent tippy-react-headless #2106

Closed
klimashkin opened this issue May 28, 2021 · 2 comments

Comments

@klimashkin
Copy link

klimashkin commented May 28, 2021

After upgrading the plugin from 2.22.0 to 2.23.3, the rule no-extraneous-dependencies complains that

 ✘  https://google.com/#q=import%2Fno-extraneous-dependencies  
‘tippy-react-headless’ should be listed in the project’s dependencies. Run ‘npm i -S tippy-react-headless’ to add it

when we import @tippyjs/react/headles like that according to the documentation

import React from 'react';
import Tippy from '@tippyjs/react/headless'; // different import path!

const HeadlessTippy = () => (
  <Tippy
    render={attrs => (
      <div className="box" tabIndex="-1" {...attrs}>
        My tippy box
      </div>
    )}
  >
    <button>My button</button>
  </Tippy>
);

But package tippy-react-headless doesn't exist in npm at all

@tarlepp
Copy link

tarlepp commented May 29, 2021

related - #2097

@klimashkin
Copy link
Author

Fixed in 2.23.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants