Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] importType: fix isExternalModule calculation #2282

Merged

Conversation

mx-bernhard
Copy link
Contributor

@mx-bernhard mx-bernhard commented Oct 29, 2021

I added a test that was red before the fix (and added some tests for the unix separator)

Fixes #2258.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (and congrats on your first PR!)

@ljharb ljharb force-pushed the feature/fix-2258-external-module-no-cycle branch from d05255a to 6682e9a Compare October 29, 2021 19:36
@ljharb ljharb changed the title fix #2258 fix isExternalModule calculation [Fix] importType: fix isExternalModule calculation Oct 29, 2021
@codecov
Copy link

codecov bot commented Oct 30, 2021

Codecov Report

Merging #2282 (6682e9a) into main (651a4d7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2282   +/-   ##
=======================================
  Coverage   94.64%   94.64%           
=======================================
  Files          65       65           
  Lines        2687     2687           
  Branches      889      889           
=======================================
  Hits         2543     2543           
  Misses        144      144           
Impacted Files Coverage Δ
src/core/importType.js 100.00% <ø> (ø)
src/rules/extensions.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 651a4d7...6682e9a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

import/no-cycle ignoreExternal does not work for external scoped modules
2 participants