Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive of no-import-module-exports on module property imported from package #2314

Closed
BarryThePenguin opened this issue Nov 30, 2021 · 1 comment

Comments

@BarryThePenguin
Copy link
Contributor

Similar to #2181, I'm seeing a false positive when using qunit with ember.

qunit exports a module property that allows tests to be grouped under a module. It also has module.only(), module.skip(), and module.todo() methods that apply behaviour to all tests in that module.

import { module, test } from 'qunit'

module.skip('A module to test', function () {
  test('A test', function () {
    ...
  })
})

The no-import-modules-exports is reporting these methods as errors.

@ljharb
Copy link
Member

ljharb commented Jan 11, 2023

Fixed by #2315.

@ljharb ljharb closed this as completed Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants