Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include security patch #2670

Closed
dipunm opened this issue Jan 12, 2023 · 1 comment
Closed

Include security patch #2670

dipunm opened this issue Jan 12, 2023 · 1 comment

Comments

@dipunm
Copy link

dipunm commented Jan 12, 2023

https://github.com/dividab/tsconfig-paths/blob/master/CHANGELOG.md#412---2023-01-02

This project relies on tsconfig-paths and this dependency should be updated to address a security vulnerability.

Issue: Prototype Pollution in JSON5 via Parse Method

@ljharb
Copy link
Member

ljharb commented Jan 12, 2023

No, it shouldn’t, for a number of reasons:

  1. it's a breaking change, see [Deps] upgrade tsconfig-paths to ^4.0.0 #2447
  2. it's unnecessary, json5 1.0.2 fixes the issue already - all everyone needs to do is update their lockfiles.
  3. it's not actually a valid vulnerability for this package, so you should just ignore it.

This is a duplicate of #2625; a duplicate of #2628; a duplicate of #2626; a duplicate of #2627; a duplicate of #2631; a duplicate of #2632; a duplicate of #2634; a duplicate of #2635; a duplicate of #2636; a duplicate of #2637; a duplicate of #2639; a duplicate of #2642; a duplicate of #2643; a duplicate of #2649; a duplicate of #2655; a duplicate of #2660.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants