[Fix] consistent-type-specifier-style: fix accidental removal of comma in certain cases
#2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mma in certain cases
|
Ah, that would probably explain a couple other weird things I saw that i thought were just me being clumsy with multi-line editing, e.g. a missing comma between type variables. Thanks for looking into this! |
ljharb
force-pushed
the
2753-remove-extra-comma-oops
branch
from
3ef4222
to
6f12316
Compare
ljharb
changed the title
consistent-type-specifier-style: fix accidental removal of comma in certain cases
|
Is there any plan for when this there will be a new point release on NPM that includes this fix? It's been merged for a while now, is there anything blocking a release? |
|
@mathiasose there's no concrete plan, just "in the next release" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2753
When passed the second argument -
getTokenAfterwill keep searching until it finds a token that matches that token - so in this bug it meant it kept scanning to the next import declaration.Using the single-arg form means it will just grab the next token and we can then check to see if that token is a comma or not (it'll either be a
}or a,).