Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] no-duplicates: Prefer combined type and regular imports when using prefer-inline #2835

Merged
merged 1 commit into from Jul 25, 2023

Conversation

benkrejci
Copy link
Contributor

@benkrejci benkrejci commented Jul 19, 2023

…refer-inline

Fixes #2834

I would expect that when using no-duplicates with "prefer-inline" option, the following would be detected as an error:

import type { Type } from "mod";
import { value } from "mod";

And would fix to:

import { type Type, value } from "mod";

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ljharb ljharb changed the title [no-duplicates] Prefer combined type and regular imports when using p… [Fix] no-duplicates: Prefer combined type and regular imports when using prefer-inline Jul 25, 2023
@ljharb ljharb merged commit f302f7d into import-js:main Jul 25, 2023
162 of 163 checks passed
@benkrejci benkrejci deleted the prefer-combined-type-imports branch July 27, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[import/no-duplicates] (prefer-inline) Does not detect across type and regular imports
4 participants