[Fix] no-extraneous-dependencies
: ignore export type { ... } from '...'
when includeTypes
is false
#2919
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
no-extraneous-dependencies
rule still checks a the dependency ofexport type { T } from 'a-dev-dependency'
even when it is supposed to exclude type only importsExample
This triggers an error
This doesn't
package.json
rule:
Fix
Check if the export statement's kind is
type
and if so, treat it like animport type
statement.