Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression] no-duplicates false positive #2934

Closed
frantic1048 opened this issue Dec 4, 2023 · 2 comments
Closed

[regression] no-duplicates false positive #2934

frantic1048 opened this issue Dec 4, 2023 · 2 comments
Labels

Comments

@frantic1048
Copy link

With latest version of eslint-plugin-import: 2.29.0
and ESLint rule 'import/no-duplicates': ['error', { 'prefer-inline': true }]

Following TypeScript code triggers no-duplicates error:

import type Highcharts from 'highcharts'
import { type SankeyNodeObject } from 'highcharts'

Expected:

no error.

Reference

Similar issue fixed in the past:

@ljharb
Copy link
Member

ljharb commented Dec 4, 2023

Why would you expect no error? Those can be combined.

@frantic1048
Copy link
Author

I apologize for any inconvenience caused. I misinterpreted the prefer-inline options during testing. Therefore, this issue is not valid.

@frantic1048 frantic1048 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2023
@ljharb ljharb added the invalid label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants